Skip to content

Update 'doAndWaitForWindow' to actually wait for the window #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labkey-tchad merged 1 commit into from
Aug 13, 2025
Merged

Update 'doAndWaitForWindow' to actually wait for the window #2623

labkey-tchad merged 1 commit into from
Aug 13, 2025

Conversation

@labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Aug 12, 2025

Rationale

The target window seems to lose its name briefly. The window was there before running system maintenance the second time and it is there in the screenshots.

org.openqa.selenium.NoSuchWindowException: Unable to locate window: systemMaintenance
  [...]
  at app//org.openqa.selenium.remote.RemoteWebDriver$RemoteTargetLocator.window(RemoteWebDriver.java:1126)
  at app//org.labkey.test.WebDriverWrapper.lambda$27(WebDriverWrapper.java:2154)
  at app//org.labkey.test.WebDriverWrapper.doAndMaybeWaitForPageToLoad(WebDriverWrapper.java:2113)
  at app//org.labkey.test.WebDriverWrapper.doAndWaitForWindow(WebDriverWrapper.java:2138)
  at app//org.labkey.test.pages.admin.ConfigureSystemMaintenancePage.runMaintenanceTask(ConfigureSystemMaintenancePage.java:29)
  at app//org.labkey.test.tests.filecontent.FileContentUploadTest.testCalculateFileRootSize(FileContentUploadTest.java:367)

doAndWaitForWindow should actually wait for the window.

Related Pull Requests

Changes

  • Update doAndWaitForWindow to actually wait for the window
  • Remove some unused and obsolete methods from LabKeyExpectedConditions

@labkey-tchad labkey-tchad merged commit 976df85 into release25.7-SNAPSHOT Aug 13, 2025
8 checks passed
@labkey-tchad labkey-tchad deleted the 25.7_fb_waitForWindow branch August 13, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-danield labkey-danield labkey-danield approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@labkey-tchad @labkey-danield